fix: add dataset edit permissions (#13223)

web/app/components/workflow/nodes/knowledge-retrieval/components/dataset-item.tsx

@@ -23,6 +23,7 @@ type Props = {
   onRemove: () => void
   onChange: (dataSet: DataSet) => void
   readonly?: boolean
+  editable?: boolean
 }
 
 const DatasetItem: FC<Props> = ({
@@ -30,6 +31,7 @@ const DatasetItem: FC<Props> = ({
   onRemove,
   onChange,
   readonly,
+  editable = true,
 }) => {
   const media = useBreakpoints()
   const { t } = useTranslation()
@@ -75,14 +77,16 @@ const DatasetItem: FC<Props> = ({
       </div>
       {!readonly && (
         <div className='hidden group-hover/dataset-item:flex shrink-0 ml-2  items-center space-x-1'>
-          <ActionButton
-            onClick={(e) => {
-              e.stopPropagation()
-              showSettingsModal()
-            }}
-          >
-            <RiEditLine className='w-4 h-4 flex-shrink-0 text-text-tertiary' />
-          </ActionButton>
+          {
+            editable && <ActionButton
+              onClick={(e) => {
+                e.stopPropagation()
+                showSettingsModal()
+              }}
+            >
+              <RiEditLine className='w-4 h-4 flex-shrink-0 text-text-tertiary' />
+            </ActionButton>
+          }
           <ActionButton
             onClick={handleRemove}
             state={ActionButtonState.Destructive}
@@ -102,7 +106,7 @@ const DatasetItem: FC<Props> = ({
       {
         payload.provider === 'external' && <Badge
           className='group-hover/dataset-item:hidden shrink-0'
-          text={t('dataset.externalTag')}
+          text={t('dataset.externalTag') as string}
         />
       }
 

web/app/components/workflow/nodes/knowledge-retrieval/components/dataset-list.tsx

@@ -1,10 +1,13 @@
 'use client'
 import type { FC } from 'react'
-import React, { useCallback } from 'react'
+import React, { useCallback, useMemo } from 'react'
 import produce from 'immer'
 import { useTranslation } from 'react-i18next'
 import Item from './dataset-item'
 import type { DataSet } from '@/models/datasets'
+import { useSelector as useAppContextSelector } from '@/context/app-context'
+import { hasEditPermissionForDataset } from '@/utils/permission'
+
 type Props = {
   list: DataSet[]
   onChange: (list: DataSet[]) => void
@@ -17,6 +20,7 @@ const DatasetList: FC<Props> = ({
   readonly,
 }) => {
   const { t } = useTranslation()
+  const userProfile = useAppContextSelector(s => s.userProfile)
 
   const handleRemove = useCallback((index: number) => {
     return () => {
@@ -35,10 +39,25 @@ const DatasetList: FC<Props> = ({
       onChange(newList)
     }
   }, [list, onChange])
+
+  const formattedList = useMemo(() => {
+    return list.map((item) => {
+      const datasetConfig = {
+        createdBy: item.created_by,
+        partialMemberList: item.partial_member_list || [],
+        permission: item.permission,
+      }
+      return {
+        ...item,
+        editable: hasEditPermissionForDataset(userProfile?.id || '', datasetConfig),
+      }
+    })
+  }, [list, userProfile?.id])
+
   return (
     <div className='space-y-1'>
-      {list.length
-        ? list.map((item, index) => {
+      {formattedList.length
+        ? formattedList.map((item, index) => {
           return (
             <Item
               key={index}
@@ -46,6 +65,7 @@ const DatasetList: FC<Props> = ({
               onRemove={handleRemove(index)}
               onChange={handleChange(index)}
               readonly={readonly}
+              editable={item.editable}
             />
           )
         })