delete the deprecated method (#5612)

This commit is contained in:
Jyong
2024-06-26 12:51:50 +08:00
committed by GitHub
parent af6e3869ff
commit 43335b5c87
19 changed files with 24 additions and 87 deletions

View File

@@ -24,9 +24,6 @@ class MilvusVectorTest(AbstractVectorTest):
hits_by_full_text = self.vector.search_by_full_text(query=get_example_text())
assert len(hits_by_full_text) == 0
def delete_by_document_id(self):
self.vector.delete_by_document_id(document_id=self.example_doc_id)
def get_ids_by_metadata_field(self):
ids = self.vector.get_ids_by_metadata_field(key='document_id', value=self.example_doc_id)
assert len(ids) == 1

View File

@@ -91,9 +91,6 @@ class TestOpenSearchVector:
assert hits_by_vector[0].metadata['document_id'] == self.example_doc_id, \
f"Expected document ID {self.example_doc_id}, got {hits_by_vector[0].metadata['document_id']}"
def test_delete_by_document_id(self):
self.vector._client.delete_by_query.return_value = {'deleted': 1}
doc = Document(page_content="Test content to delete", metadata={"document_id": self.example_doc_id})
embedding = [0.1] * 128
@@ -101,8 +98,6 @@ class TestOpenSearchVector:
mock_bulk.return_value = ([], [])
self.vector.add_texts([doc], [embedding])
self.vector.delete_by_document_id(document_id=self.example_doc_id)
self.vector._client.search.return_value = {'hits': {'total': {'value': 0}, 'hits': []}}
ids = self.vector.get_ids_by_metadata_field(key='document_id', value=self.example_doc_id)
@@ -169,10 +164,6 @@ class TestOpenSearchVectorWithRedis:
expected_doc_id = "example_doc_id"
self.tester.test_search_by_full_text(search_response, expected_length, expected_doc_id)
def test_delete_by_document_id(self):
self.tester.setup_method()
self.tester.test_delete_by_document_id()
def test_get_ids_by_metadata_field(self):
self.tester.setup_method()
self.tester.test_get_ids_by_metadata_field()

View File

@@ -26,9 +26,6 @@ class PGVectoRSVectorTest(AbstractVectorTest):
hits_by_full_text = self.vector.search_by_full_text(query=get_example_text())
assert len(hits_by_full_text) == 0
def delete_by_document_id(self):
self.vector.delete_by_document_id(document_id=self.example_doc_id)
def get_ids_by_metadata_field(self):
ids = self.vector.get_ids_by_metadata_field(key='document_id', value=self.example_doc_id)
assert len(ids) == 1

View File

@@ -81,10 +81,6 @@ class AbstractVectorTest:
def text_exists(self):
assert self.vector.text_exists(self.example_doc_id)
def delete_by_document_id(self):
with pytest.raises(NotImplementedError):
self.vector.delete_by_document_id(document_id=self.example_doc_id)
def get_ids_by_metadata_field(self):
with pytest.raises(NotImplementedError):
self.vector.get_ids_by_metadata_field(key='key', value='value')
@@ -95,7 +91,6 @@ class AbstractVectorTest:
self.search_by_full_text()
self.text_exists()
self.get_ids_by_metadata_field()
self.delete_by_document_id()
added_doc_ids = self.add_texts()
self.delete_by_ids(added_doc_ids)
self.delete_vector()

View File

@@ -43,9 +43,6 @@ class TiDBVectorTest(AbstractVectorTest):
ids = self.vector.get_ids_by_metadata_field(key='document_id', value=self.example_doc_id)
assert len(ids) == 0
def delete_by_document_id(self):
self.vector.delete_by_document_id(document_id=self.example_doc_id)
def test_tidb_vector(setup_mock_redis, setup_tidbvector_mock, tidb_vector, mock_session):
TiDBVectorTest(vector=tidb_vector).run_all_tests()