chore: improve position map conversion and tolerate empty position yaml file (#6541)

api/tests/unit_tests/utils/position_helper/test_position_helper.py

@@ -21,6 +21,20 @@ def prepare_example_positions_yaml(tmp_path, monkeypatch) -> str:
     return str(tmp_path)
 
 
+@pytest.fixture
+def prepare_empty_commented_positions_yaml(tmp_path, monkeypatch) -> str:
+    monkeypatch.chdir(tmp_path)
+    tmp_path.joinpath("example_positions_all_commented.yaml").write_text(dedent(
+        """\
+        # - commented1
+        # - commented2
+        - 
+        -   
+        
+        """))
+    return str(tmp_path)
+
+
 def test_position_helper(prepare_example_positions_yaml):
     position_map = get_position_map(
         folder_path=prepare_example_positions_yaml,
@@ -32,3 +46,10 @@ def test_position_helper(prepare_example_positions_yaml):
         'third': 2,
         'forth': 3,
     }
+
+
+def test_position_helper_with_all_commented(prepare_empty_commented_positions_yaml):
+    position_map = get_position_map(
+        folder_path=prepare_empty_commented_positions_yaml,
+        file_name='example_positions_all_commented.yaml')
+    assert position_map == {}

api/tests/unit_tests/utils/yaml/test_yaml_utils.py

@@ -53,6 +53,9 @@ def test_load_yaml_non_existing_file():
     assert load_yaml_file(file_path=NON_EXISTING_YAML_FILE) == {}
     assert load_yaml_file(file_path='') == {}
 
+    with pytest.raises(FileNotFoundError):
+        load_yaml_file(file_path=NON_EXISTING_YAML_FILE, ignore_error=False)
+
 
 def test_load_valid_yaml_file(prepare_example_yaml_file):
     yaml_data = load_yaml_file(file_path=prepare_example_yaml_file)
@@ -68,7 +71,7 @@ def test_load_valid_yaml_file(prepare_example_yaml_file):
 def test_load_invalid_yaml_file(prepare_invalid_yaml_file):
     # yaml syntax error
     with pytest.raises(YAMLError):
-        load_yaml_file(file_path=prepare_invalid_yaml_file)
+        load_yaml_file(file_path=prepare_invalid_yaml_file, ignore_error=False)
 
     # ignore error
-    assert load_yaml_file(file_path=prepare_invalid_yaml_file, ignore_error=True) == {}
+    assert load_yaml_file(file_path=prepare_invalid_yaml_file) == {}